Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds guidelines about inactive buttons #627

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Adds guidelines about inactive buttons #627

merged 5 commits into from
Nov 13, 2023

Conversation

mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Oct 12, 2023 •
edited
Loading

@mperrotti mperrotti requested a review from a team as a code owner October 12, 2023 18:49
@mperrotti mperrotti temporarily deployed to github-pages October 12, 2023 18:56 — with GitHub Actions Inactive
@mperrotti mperrotti temporarily deployed to github-pages October 12, 2023 20:38 — with GitHub Actions Inactive
pksjce
pksjce approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@pksjce pksjce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sidenote - I found it a little hard to imagine more usecases for the InactiveButton. Would it make sense to update some more? The banner example was really good. In case of service outage its a great option to have InactiveButton

@mperrotti mperrotti mentioned this pull request Oct 20, 2023
Merged
@mperrotti
Copy link
Contributor Author

There have been changes to the design based on feedback from a11y and other designers. I'll update this PR once I feel confident that everybody is aligned on the direction.

@mperrotti mperrotti merged commit 20316c9 into main Nov 13, 2023
4 checks passed
@mperrotti mperrotti deleted the mp/inactive-button branch November 13, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksjce pksjce pksjce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mperrotti @pksjce