Refactor Components to Use Separate HTML and SCSS Files #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 29, 2025 18:30
…iguratorComponent in error, login, and notfound pages
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
added 18 commits
January 31, 2025 07:46
…nd status, and adjust dialog width for better responsiveness
… in Sales component
…te service table to display price and improve dialog functionality
…t and update service list dynamically upon creation
…nt; update service selection to use API data and improve layout responsiveness
…ective and custom currency pipe for price formatting
…ssary updates; enhance price processing and add success logging
…ctor services table to enhance layout and add delete icon functionality
…igger service removal
…nctionality to use dialog for user confirmation
…hance client component styling
… and integrate dialog for creating new clients
…enhance client form with autocomplete for vehicle details
added 10 commits
February 9, 2025 10:15
…makes and types, and remove hardcoded vehicle data
…es in HttpService and integrate sales data retrieval in SalesComponent
…pdate layout for improved user experience
…e input handling for vehicle and service selection
…ice type and status display
…prove row hover effects
…and delete functionality for sales
…hance delete functionality
…nd enhance user experience for sale deletion
|
Deployment failed with the following error: |
added 18 commits
February 11, 2025 16:03
… persist settings in local storage
…l chaining and update footer content
…ds for clarity and improve update handling
… sales and clients components to use new header class
…ata binding for supplier and utility inputs
…n and refactor suppliers component for improved clarity
…mplement expense management methods in HTTP service
…logic and enhance provider selection functionality
…rm for improved data handling and readonly input
…nagement and enhance delete functionality
…gic and enhance assets form layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Angular components in the project to improve code maintainability and readability. Previously, many components had their templates and styles defined inline within the TypeScript files. As part of this update:
Templates: Extracted all inline HTML into separate .html files for each component.
Styles: Extracted all inline styles into separate .scss files for each component.
Key Benefits:
Improved Readability: Separating templates and styles from the TypeScript logic makes the codebase easier to read and navigate.
Maintainability: Modifying templates and styles independently is now more streamlined and reduces the risk of unintended changes to the TypeScript code.
Consistency: Aligns the components with Angular best practices and standard conventions.
Impact:
No changes to the functionality of the application.
All components now follow a consistent structure, making it easier for future contributors to work on the project.
Please review and let me know if further adjustments are needed!