Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InputMask): No mask on start typing #7686

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

leonardopavanello
Copy link
Contributor

@leonardopavanello leonardopavanello commented Feb 7, 2025

This is another approach to fix the "p-filled not working properly" issue( #7354)
that avoids typing issues (#7586)

Fix #7354
Fix #7586
Fix #3838

Kindly review this proposal, @mikejav @ivanpajon @melloware. Thanks! 😊

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 5:02pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 5:02pm

@leonardopavanello leonardopavanello changed the title fix(InputMask): No mask on start typing #7586 fix(InputMask): No mask on start typing Feb 7, 2025
@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Feb 7, 2025
Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melloware
Copy link
Member

@leonardopavanello i think this also fixes: #3838

@ivanpajon
Copy link
Contributor

I tested it in local and looks better than previous solution

@melloware melloware merged commit e05d31e into primefaces:master Feb 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputMask: No mask on start typing InputMask: Classname p-filled not works fine InputMask Focus Flicker
3 participants