Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#681] [fix] 프로필을 작성하지 않은 사용자가 모임 생성하지 못하도록 수정 #682

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

gxxrxn
Copy link
Member

@gxxrxn gxxrxn commented Aug 5, 2024

구현 내용

  • 추가 프로필을 등록하지 않은 사용자가 모임 생성 페이지에 접근할 수 없도록 middleware에 /group/create path를 추가했어요.

관련 이슈

@gxxrxn gxxrxn added 🐥 프론트 필수! 🐛 fix Something isn't working 🔥 v.1.0 New feature for releasing v.1.0 labels Aug 5, 2024
@gxxrxn gxxrxn requested a review from hanyugeon August 5, 2024 15:23
@gxxrxn gxxrxn self-assigned this Aug 5, 2024
Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dadok ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 3:23pm

Copy link

github-actions bot commented Aug 5, 2024

Copy link

github-actions bot commented Aug 5, 2024

⚡️ Lighthouse Average Scores Across Reports:

Category Score
🔴 performance 68
🟢 accessibility 91
🟢 best practices 98
🟢 seo 100
🟢 pwa 100

⚡️ Average Details Across All Reports:

Category Score
🟢 first contentful paint 0.8s
🔴 largest contentful paint 12.8s
🔴 interactive 7.5s
🟢 total blocking time 283.8ms
🟢 cumulative layout shift 0.0

Copy link
Member

@hanyugeon hanyugeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gxxrxn gxxrxn merged commit 17a3db5 into main Aug 6, 2024
4 checks passed
@gxxrxn gxxrxn deleted the fix/#681 branch August 6, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 fix Something isn't working 🐥 프론트 필수! 🔥 v.1.0 New feature for releasing v.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] 프로필을 작성하지 않은 사용자가 모임 생성하지 못하도록 수정
2 participants