Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#677] metadata에 프로덕션 URL만 노출되도록 수정 #678

Merged
merged 9 commits into from
Aug 8, 2024
Merged

[#677] metadata에 프로덕션 URL만 노출되도록 수정 #678

merged 9 commits into from
Aug 8, 2024

Conversation

hanyugeon
Copy link
Member

@hanyugeon hanyugeon commented Jul 30, 2024 •
edited
Loading

구현 내용

metadata에 프로덕션 URL만 노출되도록 수정

  1. 환경변수에 NEXT_DEPLOYMENT_URL를 선언했어요
NEXT_PUBLIC_PRODUCTION_URL=https://dev.dadok.app
  1. layout.tsx, sitemap.ts, robots.ts, schema.ts코드에 있는
    메타데이터와 관련된 NEXT_HOST를 제거하고, NEXT_DEPLOYMENT_URL로 대체했어요

pr 포인트

환경변수에 NEXT_DEPLOYMENT_URL를 추가해주세요!!!

NEXT_PUBLIC_PRODUCTION_URL=https://dev.dadok.app

관련 이슈

@hanyugeon hanyugeon added 🐥 프론트 필수! 🐛 fix Something isn't working 🔥 v.1.0 New feature for releasing v.1.0 labels Jul 30, 2024
@hanyugeon hanyugeon requested a review from gxxrxn July 30, 2024 15:48
@hanyugeon hanyugeon self-assigned this Jul 30, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dadok ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 0:24am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

🚀 Storybook: https://64aba10cd478ad51307a8997-vcajxemupz.chromatic.com/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚡️ Lighthouse Average Scores Across Reports:

Category Score
🔴 performance 67
🟢 accessibility 91
🟢 best practices 98
🟢 seo 100
🟢 pwa 100

⚡️ Average Details Across All Reports:

Category Score
🟢 first contentful paint 0.9s
🔴 largest contentful paint 13.0s
🔴 interactive 7.7s
🟢 total blocking time 192.6ms
🟢 cumulative layout shift 0.0

gxxrxn
gxxrxn approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@gxxrxn gxxrxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@hanyugeon hanyugeon merged commit 004bc4f into main Aug 8, 2024
4 checks passed
@hanyugeon hanyugeon deleted the fix/#677 branch August 8, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gxxrxn gxxrxn gxxrxn approved these changes

Assignees

@hanyugeon hanyugeon

Labels
🐛 fix Something isn't working 🐥 프론트 필수! 🔥 v.1.0 New feature for releasing v.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metadata에 프로덕션 URL만 노출되도록 수정
2 participants
@hanyugeon @gxxrxn