-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#669] [유저 책장] 존재하지 않는 유저 책장 페이지 예외처리 #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanyugeon
added
🐥 프론트
필수!
🐛 fix
Something isn't working
🔥 v.1.0
New feature for releasing v.1.0
labels
Jul 30, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
⚡️ Lighthouse Average Scores Across Reports:
⚡️ Average Details Across All Reports:
|
gxxrxn
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 내용
존재하지 않는 유저 프로필 페이지 예외처리
axios interceptor
에isNotFoundError
분기를 추가했어요존재하지 않는 유저 책장 페이지 예외처리
useBookShelfInfoQuery
의data.bookshelfId
값이 null(false)일 때notFound()
가 실행 되도록 했어요비로그인 상태에서 꽂은책이 없는 책장에 접근시 발생하는 에러 해결
booksData.pages[0].books[0]
에 값이 없는데Bookshelf.Books
컴포넌트 내부에서map()
을 사용하고있어 에러가 발생하였어요booksData.pages[0].books[0]
의 length가 4가 넘어가지 않는다면 더 이상 렌더링 시키지 않도록 수정했어요스크린샷
<DummyBookshelf />
만 렌더링관련 이슈