Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#669] [유저 책장] 존재하지 않는 유저 책장 페이지 예외처리 #671

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

hanyugeon
Copy link
Member

@hanyugeon hanyugeon commented Jul 30, 2024

구현 내용

존재하지 않는 유저 프로필 페이지 예외처리

  • API문서를 참고하여 axios interceptorisNotFoundError 분기를 추가했어요

존재하지 않는 유저 책장 페이지 예외처리

  • useBookShelfInfoQuerydata.bookshelfId값이 null(false)일 때 notFound()가 실행 되도록 했어요

비로그인 상태에서 꽂은책이 없는 책장에 접근시 발생하는 에러 해결

  • 기존의 코드에서 booksData.pages[0].books[0]에 값이 없는데 Bookshelf.Books 컴포넌트 내부에서 map() 을 사용하고있어 에러가 발생하였어요
  • booksData.pages[0].books[0]의 length가 4가 넘어가지 않는다면 더 이상 렌더링 시키지 않도록 수정했어요

스크린샷

  • 비로그인 상태에서 꽂은책이 4권 미만이라면 <DummyBookshelf />만 렌더링
image

관련 이슈

@hanyugeon hanyugeon added 🐥 프론트 필수! 🐛 fix Something isn't working 🔥 v.1.0 New feature for releasing v.1.0 labels Jul 30, 2024
@hanyugeon hanyugeon requested a review from gxxrxn July 30, 2024 07:11
@hanyugeon hanyugeon self-assigned this Jul 30, 2024
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dadok ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 4:43pm

Copy link

github-actions bot commented Jul 30, 2024

Copy link

github-actions bot commented Jul 30, 2024

⚡️ Lighthouse Average Scores Across Reports:

Category Score
🔴 performance 68
🟢 accessibility 91
🟢 best practices 98
🟢 seo 100
🟢 pwa 100

⚡️ Average Details Across All Reports:

Category Score
🟢 first contentful paint 0.8s
🔴 largest contentful paint 13.0s
🔴 interactive 7.8s
🟢 total blocking time 297.5ms
🟢 cumulative layout shift 0.0

Copy link
Member

@gxxrxn gxxrxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!! 💯

@hanyugeon hanyugeon merged commit 58200d7 into main Aug 5, 2024
4 checks passed
@hanyugeon hanyugeon deleted the fix/#669 branch August 8, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 fix Something isn't working 🐥 프론트 필수! 🔥 v.1.0 New feature for releasing v.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

존재하지 않는 유저 책장, 프로필 페이지 예외처리
2 participants