-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): add tests for ESLint 8 #428
Conversation
a964de9
to
e5af184
Compare
If you rebase, a lot of this goes away. It looks like CI has passed successfully though, so it seems we're all v8 compliant. I'd prefer to avoid testing pre-release versions though if possible so I'm tempted to close this, and we can revisit once v8.0.0 is released. |
e5af184
to
6b17952
Compare
@BPScott Rebased onto I've also updated all ESLint-related dependencies to their latest versions. |
fea2628
to
04747df
Compare
04747df
to
59910cb
Compare
59910cb
to
85ee07b
Compare
Hey! When will be this new version published? It didn't trigger any new release since it was merged as a chore, but this should be a new minor adding compatibility for ESLint v8. |
This PR changed development-only dependencies and what we run in CI. There were no code changes required to support eslint 8, what is already published to npm is sufficient. |
Hi, I think you need to update peerDependencies as well.
|
|
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) | devDependencies | minor | [`4.0.0` -> `4.1.0`](https://renovatebot.com/diffs/npm/eslint-plugin-prettier/4.0.0/4.1.0) | --- ### Release Notes <details> <summary>prettier/eslint-plugin-prettier</summary> ### [`v4.1.0`](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#v410-2022-06-27) [Compare Source](prettier/eslint-plugin-prettier@v4.0.0...v4.1.0) - feat: skip processing code blocks on specific languages like `stylelint-prettier` ([#​415](prettier/eslint-plugin-prettier#415)) ([52eec48](prettier/eslint-plugin-prettier@52eec48)) - build(deps): Bump minimist from 1.2.5 to 1.2.6 ([#​464](prettier/eslint-plugin-prettier#464)) ([42bfe88](prettier/eslint-plugin-prettier@42bfe88)) - build(deps-dev): Bump graphql from 15.5.1 to 15.7.2 ([#​442](prettier/eslint-plugin-prettier#442)) ([0158640](prettier/eslint-plugin-prettier@0158640)) - build(deps-dev): Bump [@​graphql-eslint/eslint-plugin](https://github.com/graphql-eslint/eslint-plugin) from 2.3.0 to 2.4.0 ([#​444](prettier/eslint-plugin-prettier#444)) ([4bcaca2](prettier/eslint-plugin-prettier@4bcaca2)) - chore(CI): add tests for ESLint 8 ([#​428](prettier/eslint-plugin-prettier#428)) ([f3713be](prettier/eslint-plugin-prettier@f3713be)) - README.md: HTTP => HTTPS ([#​443](prettier/eslint-plugin-prettier#443)) ([44e1478](prettier/eslint-plugin-prettier@44e1478)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1435 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
ESLint v8.0.0 is released 🎉
devDependency compatibility with ESLint 8:
@graphql-eslint/eslint-plugin
(Support ESLint 8.x dimaMachina/graphql-eslint#595)v2.3.0
eslint-plugin-eslint-plugin
(Support ESLint 8.x eslint-community/eslint-plugin-eslint-plugin#175)meta.hasSuggestions
property tometa-property-ordering
rule eslint-community/eslint-plugin-eslint-plugin#119v4.0.0-0
v4.0.0
eslint-plugin-graphql
(Support ESLint 8.x apollographql/eslint-plugin-graphql#310)eslint-plugin-node
(Support ESLint 8.x mysticatea/eslint-plugin-node#294)vue-eslint-parser
ReleaseI wanted to update
eslint-config-prettier
,eslint-plugin-eslint-plugin
,eslint-plugin-node
&vue-eslint-parser
to their latest minor, but that would break CI on the older ESLint/Node versionsIf wanted, I can do it in this PR or make a second PR with all the breaking changes.
Edit: This can be done without a breaking change after #429 is merged
Closes #427