Fix ECMA version in internal ESLint config #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our internal ESLint config says
ecmaVersion: 2018, but still allows syntax from ES2019+ since we also use@babel/parser.This PR changes to using the default parser, except for react and flow where we use babel (for JSX and type annotations).
At some point we could bump
ecmaVersionto be able to use newer language features, but right now that’s an unnecessary potentially breaking change. We only test supported Node.js in GitHub Actions, but I just tested manually and eslint-config-prettier still works in Node.js 12 which is just two LTS behind. Given eslint-config-prettier’s popularity I see no reason to break that for now.See the individual commits for details.