Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks of common configuration requirements to the UI #6

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

raphaelm
Copy link
Member

No description provided.

pretix_zugferd/templates/pretix_zugferd/settings.html Outdated Show resolved Hide resolved
processes the electronic invoices automatically might not take them account. Make sure they do
not include vital details on payment or taxation matters.
{% endblocktrans %}
<a href="{% url "control:event.settings.invoice" event=request.event.slug organizer=request.event.organizer.slug %}#id_invoice_introductory_text_0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="{% url "control:event.settings.invoice" event=request.event.slug organizer=request.event.organizer.slug %}#id_invoice_introductory_text_0"
<a href="{% url "control:event.settings.invoice" event=request.event.slug organizer=request.event.organizer.slug %}#id_invoice_introductory_text_1"

...the text areas all have _1 instead of _0 in their IDs now, not sure why or when that changed though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waaah, I fear that is language-dependent! 😢

information (e.g. registration numbers, management board) on both the PDF and XML part of the
ZUGFeRD invoice.
{% endblocktrans %}
<a href="{% url "control:event.settings.invoice" event=request.event.slug organizer=request.event.organizer.slug %}#id_invoice_footer_text_0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="{% url "control:event.settings.invoice" event=request.event.slug organizer=request.event.organizer.slug %}#id_invoice_footer_text_0"
<a href="{% url "control:event.settings.invoice" event=request.event.slug organizer=request.event.organizer.slug %}#id_invoice_footer_text_1"

<span class="fa fa-fw fa-warning text-danger"></span>
{% trans "X-Rechnung is active, but customers cannot enter a Leitweg ID." %}
{% trans "If you expect German governmental customers, we recommend using the custom field to allow them to enter a Leitweg ID." %}
<a href="{% url "control:event.settings.invoice" event=request.event.slug organizer=request.event.organizer.slug %}#id_invoice_address_custom_field_0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="{% url "control:event.settings.invoice" event=request.event.slug organizer=request.event.organizer.slug %}#id_invoice_address_custom_field_0"
<a href="{% url "control:event.settings.invoice" event=request.event.slug organizer=request.event.organizer.slug %}#id_invoice_address_custom_field_1"

pretix_zugferd/views.py Outdated Show resolved Hide resolved
@raphaelm raphaelm merged commit d173417 into master Dec 16, 2024
4 of 5 checks passed
@raphaelm raphaelm deleted the check-ux branch December 16, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants