Message_Bank_Pokedex and Pokedex_Height_Check #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ov21_021E6014 -> pokedex_weight_check message_bank_unk_0697 -> message_bank_pokedex Identified all uses of message_bank_pokedex Started documentation of pokedex_weight_check
Fixed Misidentifications
h2o-DS
changed the title
lhearachel
reviewed
Jan 15, 2025
Added all found gmm constants for message_bank_pokedex Renamed message_bank_pokedex gmm constants Documented several simple functions
|
Added all the gmm constants I could find for this message bank. Will make identifying future files in overlay 21 much easier. |
lhearachel
reviewed
Jan 19, 2025
Changed instances of `int heapID` in overlay021 to `enum HeapId heapID`
DisplayMessage -> Pokedex_DisplayMessage
|
I have changed all instances of |
lhearachel
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ov21_021E6014 -> pokedex_height_check
message_bank_unk_0697 -> message_bank_pokedex
Identified all uses of message_bank_pokedex
Started documentation of pokedex_height_check, the screen in the pokedex where the pokemon is compared to the trainer's silhouette.
There are still a decent amount undocumented because there are a couple structs that are widely used across overlay 21 that I don't feel confident enough naming yet.