Start Syncing HGSS Battle Loading - Preliminary cleanup #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reformat according to |
|
Ready to review -- sorry bout the delays |
lhearachel
reviewed
Jan 15, 2025
| @@ -4475,7 +4475,7 @@ | |||
| .short \arg0 | |||
| .endm | |||
|
|
|||
| .macro ScrCmd_337 arg0, arg1 | |||
| .macro ScrCmd_HasSeenSpecies arg0, arg1 | |||
There was a problem hiding this comment.
polish: Rename the ASM macros without the ScrCmd_ prefix.
Also, if you could document the arguments on the macro, that would be much appreciated. 🙏
| @@ -7,7 +7,7 @@ typedef struct { | |||
| u32 unk_00; | |||
| int unk_04; | |||
| int unk_08[4]; | |||
| TrainerData unk_18[4]; | |||
| Trainer unk_18[4]; | |||
There was a problem hiding this comment.
note: Just noting here that we aren't documenting this right now without further info.
| BOOL sub_0206B044(VarsFlags *varsFlags, u16 param1); | ||
| u16 sub_0206B054(VarsFlags *varsFlags); | ||
| u16 sub_0206B064(VarsFlags *varsFlags); | ||
| u16 VarsFlags_GetProfessorAssistantStarterSpecies(VarsFlags *varsFlags); |
There was a problem hiding this comment.
suggestion: GetPlayerCounterpartStarterSpecies.
|
|
||
| void PoketchData_Enable(PoketchData *poketchData); | ||
| void PoketchData_Enable(Poketch *poketch); |
There was a problem hiding this comment.
suggestion: Rename PoketchData -> Poketch. (and the file from poketch_data.c to poketch.c)
| @@ -6,48 +6,48 @@ | |||
| #include "pokemon.h" | |||
There was a problem hiding this comment.
suggestion: Should we rename the files to pokedex.{c,h}?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.