Improve mwrap to allow out-of-tree builds #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mid-kid
commented
Mar 8, 2024
mid-kid
commented
- Use meson subcommands in build.sh and clean.sh
- mwrap: Improve pathsep shenanigans
- mwrap: Separate source and build directory
mid-kid
added a commit
to mid-kid/pokeplatinum
that referenced
this pull request
Mar 8, 2024
This allows the build directory to be located outside of the source tree. Arguably, this has no tangible benefit, but it's more "proper" in the meson spirit. Depends on the following PRs: - pret#155 - ntrtwl/libvct#1 - ntrtwl/NitroDWC#2 - ntrtwl/NitroSDK#1 - ntrtwl/NitroWiFi#1
Merged
mid-kid
added a commit
to mid-kid/pokeplatinum
that referenced
this pull request
Mar 8, 2024
This allows the build directory to be located outside of the source tree. Arguably, this has no tangible benefit, but it's more "proper" in the meson spirit. Depends on the following PRs: - pret#155 - ntrtwl/libvct#1 - ntrtwl/NitroDWC#2 - ntrtwl/NitroSDK#1 - ntrtwl/NitroWiFi#1
lhearachel
reviewed
Mar 8, 2024
build.sh
Outdated
| @@ -10,4 +11,4 @@ fi | |||
| export NINJA_STATUS="[%p %f/%t] " | |||
|
|
|||
| # Build the project | |||
| ninja -C build "$target" "$@" | |||
| "${MESON:-meson}" compile -C build "$target" "$@" | |||
There was a problem hiding this comment.
Shouldn't this be meson test?
mid-kid
added a commit
to mid-kid/pokeplatinum
that referenced
this pull request
Mar 8, 2024
This allows the build directory to be located outside of the source tree. Arguably, this has no tangible benefit, but it's more "proper" in the meson spirit. Depends on the following PRs: - pret#155 - ntrtwl/libvct#1 - ntrtwl/NitroDWC#2 - ntrtwl/NitroSDK#1 - ntrtwl/NitroWiFi#1
This allows the project to be built outside of the source directory of the repository.
lhearachel
approved these changes
Mar 8, 2024
mid-kid
added a commit
to mid-kid/pokeplatinum
that referenced
this pull request
Mar 8, 2024
This allows the build directory to be located outside of the source tree. Arguably, this has no tangible benefit, but it's more "proper" in the meson spirit. Depends on the following PRs: - pret#155 - ntrtwl/libvct#1 - ntrtwl/NitroDWC#2 - ntrtwl/NitroSDK#1 - ntrtwl/NitroWiFi#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.