Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build experience tables from source #147

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Build experience tables from source #147

merged 4 commits into from
Feb 14, 2024

Conversation

wildfire248
Copy link
Contributor

Builds tables for mapping level to experience (pl_growtbl.narc) from source.
Also edits associated functions to use enum PokemonExpRate from generated constants instead of int for which table is read.

lhearachel
lhearachel reviewed Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@lhearachel lhearachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an entry where I would argue in favor of CSV, since the user experience of trying to tune level curves on a particular level breakpoint isn't great with JSON. Thoughts?

@lhearachel lhearachel merged commit 45fc686 into pret:main Feb 14, 2024
1 check passed
@lhearachel lhearachel mentioned this pull request Feb 14, 2024
Open
13 tasks
github-actions bot pushed a commit that referenced this pull request Feb 14, 2024
@lhearachel
Merge pull request #147 from wildfire248/growtbl
07dd925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhearachel lhearachel lhearachel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wildfire248 @lhearachel