Move heal locations data to their associated map.json #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data that was in
src/data/heal_locations.h
is now distributed acrossmap.json
files, andmapjson
will use that data to automatically generateheal_locations.h
.The primary reason for this change is that currently Porymap overwrites
heal_locations.h
, which means that users are very limited in what they can do with heal location data. Now thatmapjson
has that responsibility the heal location C data can be formatted arbitrarily.There are a few smaller benefits as well. For one, the data for each heal location is neatly collected in one object, rather than spread across 3 different arrays. The
respawn_map
andrespawn_npc
fields are also much closer now to their corresponding warp and object event, so it should be much easier to notice when one of them needs to be updated.From a build process standpoint it would be easier to put this data in a single combined
heal_locations.json
file, but I think this loses out on the organizational benefits above.