Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mateon 2024 sep #215

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Mateon 2024 sep #215

merged 8 commits into from
Sep 18, 2024

Conversation

mateon1
Copy link
Contributor

@mateon1 mateon1 commented Sep 15, 2024

Major renames, script callbacks, cleanup

src/code.c Outdated Show resolved Hide resolved
Copy link
Contributor

@DizzyEggg DizzyEggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also something to consider while naming string variables. In pokeemerald we usually follow the convention of gText_
Maybe it would be a good idea to have something similar done in this repo as well?

asm/text.s Outdated Show resolved Hide resolved
@SethBarberee SethBarberee self-assigned this Sep 15, 2024
@SethBarberee
Copy link
Collaborator

Not opposed to it. I'm not heavily one side or another, to be honest.

asm/code_8010F28.s Outdated Show resolved Hide resolved
@mateon1
Copy link
Contributor Author

mateon1 commented Sep 18, 2024

Sorry for the delay, review comments addressed, should be ready for merge.

@AnonymousRandomPerson
Copy link
Collaborator

Not really for or against the gText convention either. I'll merge this PR for now, and if anyone's up for going through and renaming all the globals then that can be its own PR.

@AnonymousRandomPerson AnonymousRandomPerson merged commit c4dd5fe into pret:master Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants