-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native] Add support for DEPENDENCY_DIR, INSTALL_PREFIX, PYTHON_VENV #23776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Please update the release section in the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the doc! A couple of minor nits, and a suggestion to rephrase for easier understanding.
c3466c1
to
1c8b3fb
Compare
@steveburnett can you take another look? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
8505bb4
1c8b3fb
to
8505bb4
Compare
8505bb4
to
e4bfb1f
Compare
@tdcmeehan can you please help approve and merge this? Thanks. |
Description
DEPENDENCY_DIR and INSTALL_PREFIX help developers manage dependencies.
PYTHON_VENV is used to configure the clang-format package.
Motivation and Context
Impact
Test Plan
Contributor checklist
If release note is NOT required, use: