Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support decimal and time data types #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m1n0
Copy link

@m1n0 m1n0 commented Oct 13, 2023

This is roughly a copy of what Trino did here trinodb/trino-python-client#160 - with two exceptions:

  • no tests - I dont see dbapi tests in general in this repo
  • I added the experimental boolean flag to the connection itself, that seems to make more sense to me rather than adding it to the cursor.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: m1n0 / name: Milan Lukac (90944f0)

@tdcmeehan tdcmeehan self-assigned this Oct 16, 2023
@m1n0
Copy link
Author

m1n0 commented Oct 31, 2023

is there something blocking this @tdcmeehan ?

@tdcmeehan
Copy link

@m1n0 can you please ask for help in the PrestoDB Slack to get this PR moving? I am not a Python expert, but I can help provide a surface review later.

@m1n0
Copy link
Author

m1n0 commented Dec 13, 2023

thanks for the comment @tdcmeehan ! I already did that when I opened the PR, I just asked again now.

@wanglinsong
Copy link
Member

I can deploy a cluster in AWS and let you try this out.

@m1n0
Copy link
Author

m1n0 commented Apr 29, 2024

hi, what can I do to move this forward?

@wanglinsong
Copy link
Member

hi, what can I do to move this forward?

Please run some BAT tests to make sure the new updates work.
You can deploy a local cluster, or I can provide one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants