Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Http Server with two https ports #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jingmeih
Copy link

@jingmeih jingmeih commented Dec 5, 2022

We are working on deprecating presto proxy in favor of proxygen. Proxygen uses a different certificate than presto proxy, in order to be compatible with our current presto proxy, we decide to listen to two HTTPS ports at the same time.

==TEST==

  1. TestHttpServerConfig
  2. TestHttpServerInfo
  3. TestHttpServerProvider

Enable http server with another alternative https port,
this gives us the freedom that if the second port is needed.
@ajaygeorge
Copy link

@jingmeih Can we have the new code path under a flag so that we don't have to open 2 ports at the same time.

@jingmeih
Copy link
Author

jingmeih commented Dec 7, 2022

@jingmeih Can we have the new code path under a flag so that we don't have to open 2 ports at the same time.

I added the flag on line(https://github.com/prestodb/airlift/pull/60/files#diff-1762da6fd46b87f7b857cf8ed43e4fe754589ef8f66ba0f4f79b0490d408b5acR188), let me know if this is not enough.

Copy link

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can two different certificates be used for the two different ports?

@jingmeih
Copy link
Author

jingmeih commented Jan 4, 2023

Can two different certificates be used for the two different ports?

The way I am thinking is to have two keystores, the additional keystore is for the new port.

@wanglinsong wanglinsong requested a review from a team as a code owner August 1, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants