feat(tests): unit test added for DOCUMENT_ADDED with subcollection - #…

…101
prescottprue · May 20, 2018 · 267adfb · 267adfb
1 parent 84c0a6e
commit 267adfb
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 7 deletions.
diff --git a/src/reducers/orderedReducer.js b/src/reducers/orderedReducer.js
@@ -27,14 +27,15 @@ const {
  * @return {Array} State with document modified
  */
 function modifyDoc(collectionState, action) {
-  const { meta, payload } = action;
-  if (!meta.subcollections || meta.storeAs) {
+  if (!action.meta.subcollections || action.meta.storeAs) {
     return updateItemInArray(collectionState, action.meta.doc, item =>
       // Merge is used to prevent the removal of existing subcollections
       mergeObjects(item, action.payload.data),
     );
   }
-  const [, docId, subcollectionName, subDocId] = pathToArr(meta.path);
+
+  // TODO: make this recurisve so it will work multiple subcollections deep
+  const [, docId, subcollectionName, subDocId] = pathToArr(action.meta.path);
 
   // Update document item within top arra
   return updateItemInArray(collectionState, docId, item => ({
@@ -43,7 +44,7 @@ function modifyDoc(collectionState, action) {
       get(item, subcollectionName, []),
       subDocId,
       // Merge with existing subcollection doc (only updates changed keys)
-      subitem => mergeObjects(subitem, payload.data),
+      subitem => mergeObjects(subitem, action.payload.data),
     ),
   }));
 }

diff --git a/test/unit/reducers/orderedReducer.spec.js b/test/unit/reducers/orderedReducer.spec.js
@@ -20,17 +20,54 @@ describe('orderedReducer', () => {
       it('adds a document when collection is empty', () => {
         const collection = 'test1';
         const doc = 'test2';
-        const someDoc = { id: doc };
+        const someDoc = { some: 'value' };
         const payload = {
           ordered: { newIndex: 0, oldIndex: -1 },
           data: someDoc,
         };
         const meta = { collection, doc };
         action = { meta, payload, type: actionTypes.DOCUMENT_ADDED };
         const result = orderedReducer({}, action);
+        // Id is set
+        expect(result).to.have.nested.property(`${collection}.0.id`, doc);
+        // Value is set
         expect(result).to.have.nested.property(
-          `${collection}.0.id`,
-          someDoc.id,
+          `${collection}.0.some`,
+          someDoc.some,
+        );
+      });
+
+      it('adds a subcollection document when collection is empty', () => {
+        const collection = 'test1';
+        const doc = 'test2';
+        const subcollection = 'test3';
+        const subdoc = 'test4';
+        const fakeDoc = { some: 'value' };
+        const payload = {
+          ordered: { newIndex: 0, oldIndex: -1 },
+          data: fakeDoc,
+        };
+        const meta = {
+          collection,
+          doc,
+          subcollections: [{ collection: subcollection }],
+          path: `${collection}/${doc}/${subcollection}/${subdoc}`,
+        };
+        action = {
+          meta,
+          payload,
+          type: actionTypes.DOCUMENT_ADDED,
+        };
+        const result = orderedReducer({}, action);
+        // Id is set
+        expect(result).to.have.nested.property(
+          `${collection}.0.${subcollection}.0.id`,
+          subdoc,
+        );
+        // Value is set
+        expect(result).to.have.nested.property(
+          `${collection}.0.${subcollection}.0.some`,
+          fakeDoc.some,
         );
       });
     });