feat: add reproducible and non reproducible states #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichmor
approved these changes
Jun 26, 2024
| def get_build_state_fa(build_state: BuildState): | ||
| if build_state == BuildState.SUCCESS: | ||
| return "fa-solid fa-check text-green-600" | ||
| reproducible = "fa-solid fa-thumbs-up text-green-600" |
There was a problem hiding this comment.
let's use UPPER_CASE for them
| if build_state == BuildState.SUCCESS and ( | ||
| rebuild_state is None or rebuild_state == BuildState.SUCCESS | ||
| ): | ||
| return reproducible |
There was a problem hiding this comment.
small qq:
if we dont have rebuild state, maybe we could have unknown state?
like the one at the end:
return "fa-solid fa-question"
|
will add them in next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds seperate states for reproducible and non-reproducible builds.