Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimental indent when logging to terminal #592

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Feb 5, 2024

TODO:

  • refactor run_in_env so that we can use it both in tests and build execution
  • Add more span! (e.g. when running the tests)
  • make interpreter selectable while we are at it :)
  • Test rebuild and test subcommands
  • Add "summary" function after the build(s) is done

Still needs fixing:

  • Summary is nice, but needs some more tweaks:
    • Add a Github subscriber that prints warning as ::warning::{message} and error as ::error::{message}
    • Make the summary have proper tables

@wolfv wolfv force-pushed the experimental-indent branch from 1c2f133 to 267650b Compare February 15, 2024 11:44
@wolfv
Copy link
Member Author

wolfv commented Feb 15, 2024

It's starting to look cool: https://asciinema.org/a/640577

@@ -134,7 +133,7 @@ pub async fn create_environment(
platform,
&repodata_cache,
download_client.clone(),
tool_configuration.multi_progress_indicator.clone(),
tool_configuration.fancy_log_handler.clone(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing name lol

Copy link
Contributor

@schuylermartin45 schuylermartin45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straight forward, looks good.

@wolfv wolfv force-pushed the experimental-indent branch from 7f655b1 to af30a85 Compare February 18, 2024 17:07
@pavelzw
Copy link
Collaborator

pavelzw commented Feb 19, 2024

The "install yq with chocolatey" ci step seems to fail quite often... We could do prefix-dev/setup-pixi and afterwards pixi global install yq...

@wolfv wolfv force-pushed the experimental-indent branch from 3e4faf5 to 0140c76 Compare February 20, 2024 08:41
@wolfv wolfv marked this pull request as ready for review February 20, 2024 09:10
@wolfv wolfv merged commit 5d8bafe into prefix-dev:main Feb 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants