Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: latest_tag get oldest tag #1062

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix: latest_tag get oldest tag #1062

merged 1 commit into from
Sep 20, 2024

Conversation

fecet
Copy link
Contributor

@fecet fecet commented Sep 20, 2024

The current implementation of git.latest_tag seems a bit off. Using -v:refname together with last() is actually selecting the earliest tag, not the latest one.

One can check this by

context:
  git_repo_url: https://github.com/prefix-dev/rattler-build.git
  latest_tag: ${{ git.latest_tag( git_repo_url ) }}

package:
  name: "rattler"
  version: ${{ latest_tag }}

source:
  git: ${{ git_repo_url }}
  tag: ${{ latest_tag }}

@wolfv
Copy link
Member

wolfv commented Sep 20, 2024

great, thanks!

@wolfv wolfv merged commit f2da23d into prefix-dev:main Sep 20, 2024
15 checks passed
wolfv pushed a commit to wolfv/rattler-build that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants