Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pixi add suggestions on not found #3048

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: pixi add suggestions on not found #3048

wants to merge 3 commits into from

Conversation

ruben-arts
Copy link
Contributor

@ruben-arts ruben-arts commented Feb 1, 2025 •
edited
Loading

Continuation of the work in #3039 by @sanchopanca

TODO:

  • Figure out a way to make it faster, as this is a 20% hit in performance as is.

@ruben-arts ruben-arts changed the title Feat/add suggestions feat: pixi add suggestions on not found Feb 1, 2025
@Hofer-Julian
Copy link
Contributor

Hofer-Julian commented Feb 3, 2025 •
edited
Loading

I've pushed a few improvements with 3c352c2

The timeout is needed since pixi search can take really long (>10sec) depending on the search string. It is also not clear yet to me why the search string *pydantix* returns pydantic. Want to investigate both first, before merging this PR

@ruben-arts ruben-arts marked this pull request as draft February 3, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruben-arts @Hofer-Julian @sanchopanca