feat: Add S3 backend support #2825
Open
+3,593
−587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks guys, I'm asking @baszalmstra for a review of this work. |
|
this first version should be ready for review as well, only a couple smaller things missing |
|
fyi we temporarily removed the secrets to see if that fixes our release build. |
pavelzw
reviewed
Jan 14, 2025
crates/pixi_utils/src/reqwest.rs
Outdated
Comment on lines
119
to
128
| // todo: is from_env correct? | ||
| debug!("Using s3_config: {:?}", s3_config); | ||
| let s3_middleware = if let Some(s3_config) = s3_config { | ||
| S3Middleware::new(s3_config, AuthenticationStorage::from_env().unwrap()) | ||
| } else { | ||
| S3Middleware::new( | ||
| config.compute_s3_config(), | ||
| AuthenticationStorage::from_env().unwrap(), | ||
| ) | ||
| }; |
There was a problem hiding this comment.
depends on conda/rattler#1026 and #2909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of a series of PRs for implementing conda/rattler#960.
Changes
Add S3 backend support for
pixi.tomland global pixi config.Joint work with @moritzwilksch and @pavelzw.