Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch pixi dependency back to prefix-dev #37

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

Hofer-Julian
Copy link
Contributor

Switching to my repo was necessary to have green CI. Now that everything is merged, we can go back.

Switching to my repo was necessary to have green CI.
Now that everything is merged, we can go back.
Copy link
Contributor

@nichmor nichmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question about pinning, apart from that I agree!

@@ -31,17 +31,16 @@ jsonrpc-stdio-server = "18.0.0"
jsonrpc-http-server = "18.0.0"
jsonrpc-core = "18.0.0"

rattler-build = { git = "https://github.com/prefix-dev/rattler-build", branch = "main", default-features = false }
rattler-build = { git = "https://github.com/prefix-dev/rattler-build", rev = "b3f6bd25067177a4b7937a3960d2e2da196b249a", default-features = false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to point to specific rev instead of main?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, rattler-build introduces some breaking changes, that don't make sense to fix within this PR. See also the discussion on discord

@Hofer-Julian Hofer-Julian merged commit 04d32f9 into prefix-dev:main Dec 16, 2024
13 checks passed
@Hofer-Julian Hofer-Julian deleted the fix/switch-back-main branch December 16, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants