Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel transport with remeshing #599

Merged
merged 22 commits into from
Dec 10, 2024

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Nov 26, 2024

This PR adds support for adaptive mesh refinement to the transport solver of the channel transport tutorial.

The transport-nutils runs normally without arguments.
Using ./run.sh remesh=True enables adaptive mesh refinement every 2 time windows. This mode starts with a mesh of a quarter of the total cells.
Using ./run.sh remesh=True frequency=5 sets the refinement frequency to every 5 time windows.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@fsimonis fsimonis requested a review from MakisH November 26, 2024 11:37
@fsimonis fsimonis self-assigned this Nov 26, 2024
@uekerman
Copy link
Member

uekerman commented Nov 26, 2024

This is the case that we specifically set up as a testcase for remeshing. No need to copy in my opinion. Simply edit it directly.

#269

@fsimonis
Copy link
Member Author

@uekerman This way, we lose our simple volume-coupling case though.

@uekerman
Copy link
Member

There are enough other cases for volume coupling.

@fsimonis fsimonis requested a review from uekerman November 29, 2024 11:04
@fsimonis
Copy link
Member Author

Merged the solvers, and updated OP

@fsimonis fsimonis removed the request for review from uekerman December 9, 2024 12:04
@fsimonis fsimonis requested a review from MakisH December 9, 2024 12:04
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice test case! 👍

I ran it and the results look good: I see the updated mesh, and the simulation completes normally.

  • The fluid-nutils/transport-nutils case took me 2h.
  • The fluid-openfoam/transport-nutils case took me 20min.

Not sure if it makes sense to document somewhere that Nutils, especially the fluid-nutils, takes comparatively too long. Mainly to guide the user to prefer the faster OpenFOAM case and to not blame the runtime solely on preCICE.

@fsimonis fsimonis merged commit 29ab244 into precice:develop Dec 10, 2024
1 check passed
@fsimonis fsimonis deleted the channel-transport-remeshing branch December 10, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants