Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rise: Update bidder info yaml #4039

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rise: Update bidder info yaml #4039

wants to merge 4 commits into from

Conversation

zkosanovic
Copy link
Contributor

No description provided.

SyntaxNode
SyntaxNode reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@SyntaxNode SyntaxNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you're updating the bidder info, does Rise support OpenRTB 2.6? That's another potential setting to declare in the bidder info.

static/bidder-info/rise.yaml
@@ -8,6 +11,7 @@ capabilities:
mediaTypes:
- banner
- video
- native
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new media type requires accompanying json tests with requests for that new media type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a native JSON test

@zkosanovic
Copy link
Contributor Author

@SyntaxNode as of right now, we don't support OpenRTB 2.6

SyntaxNode
SyntaxNode reviewed Nov 6, 2024
View reviewed changes
adapters/rise/risetest/exemplary/simple-native.json Outdated
"crid": "29681110",
"h": 250,
"w": 300,
"mtype": 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mtype should be 4 for native.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c517a3a

rise

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rise/rise.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:30:	MakeRequests		81.8%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:56:	MakeBids		88.9%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:93:	extractOrg		100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:117:	getMediaTypeForBid	100.0%
total:								(statements)		91.7%

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6de7ab5

rise

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rise/rise.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:30:	MakeRequests		81.8%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:56:	MakeBids		88.9%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:93:	extractOrg		100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:117:	getMediaTypeForBid	100.0%
total:								(statements)		91.7%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyntaxNode SyntaxNode Awaiting requested review from SyntaxNode

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkosanovic @SyntaxNode