Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules: Carry context from incoming requests to hooks #4007

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Modules: Carry context from incoming requests to hooks #4007

wants to merge 8 commits into from

Conversation

scr-oath
Copy link

This change

  1. Allows disconnects from the server to cancel further work
  2. Uses the same timeout via Done channel rather than using (and leaking; never canceling) a time.After timer for every stage.
  3. Recovers from panics, which would previously halt the app
  4. Doesn't run hooks when the context is already failed (such as when client navigates away).

@bsardo bsardo changed the title Fixes 3962 Ensure that the context carries all the way through the incoming request to the module hooks Modules: Carry context from incoming requests to hooks Oct 23, 2024
@scr-oath
Copy link
Author

scr-oath commented Nov 4, 2024

Fixes #3962

@scr-oath scr-oath mentioned this pull request Nov 4, 2024
Open
@bsardo
Copy link
Collaborator

bsardo commented Nov 4, 2024

Hi @scr-oath, can you please merge with master and resolve conflicts? Thanks!

@scr-oath
Copy link
Author

scr-oath commented Nov 6, 2024

Hi @scr-oath, can you please merge with master and resolve conflicts? Thanks!

DONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scr-oath @bsardo