Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Update NextMillennium bidder #3103

Merged
merged 5 commits into from
May 22, 2024

Conversation

marki1an
Copy link
Collaborator

@marki1an marki1an commented Apr 8, 2024

No description provided.

@marki1an marki1an self-assigned this Apr 8, 2024
@AntoxaAntoxic
Copy link
Collaborator

Overall looks good, but I suggest it's worth refactoring the makeHttpRequests method to make it aligned with other bidder implementations

AntoxaAntoxic
AntoxaAntoxic previously approved these changes Apr 18, 2024
@SerhiiNahornyi SerhiiNahornyi merged commit f10fbe4 into master May 22, 2024
5 checks passed
@SerhiiNahornyi SerhiiNahornyi deleted the update-next-millennium-bidder branch May 22, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: Nextmillennium: add video support & fix server object
3 participants