Migrate PBS from using embedded Vert.x to verticles #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And1sS
changed the title
SerhiiNahornyi
requested changes
Apr 23, 2023
src/main/java/org/prebid/server/vertx/verticles/VerticleDeployer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/vertx/verticles/server/ServerVerticle.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/vertx/verticles/server/application/ApplicationResource.java
Show resolved
Hide resolved
SerhiiNahornyi
requested changes
Feb 23, 2024
src/main/java/org/prebid/server/spring/config/server/admin/AdminServerAuthProvider.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/org/prebid/server/handler/info/BiddersHandler.java # src/main/java/org/prebid/server/privacy/gdpr/vendorlist/VendorListService.java # src/main/java/org/prebid/server/privacy/gdpr/vendorlist/VendorListServiceV2.java # src/main/java/org/prebid/server/spring/config/PrivacyServiceConfiguration.java # src/main/java/org/prebid/server/spring/config/SettingsConfiguration.java # src/main/java/org/prebid/server/spring/config/VertxConfiguration.java # src/main/resources/application.yaml # src/test/java/org/prebid/server/privacy/gdpr/vendorlist/VendorListServiceTest.java
# Conflicts: # src/main/java/org/prebid/server/deals/AlertHttpService.java # src/main/java/org/prebid/server/deals/DeliveryStatsService.java # src/main/java/org/prebid/server/deals/PlannerService.java # src/main/java/org/prebid/server/deals/RegisterService.java # src/main/java/org/prebid/server/deals/UserService.java # src/main/java/org/prebid/server/deals/simulation/SimulationAwareDeliveryStatsService.java # src/main/java/org/prebid/server/deals/simulation/SimulationAwareHttpBidderRequester.java # src/main/java/org/prebid/server/deals/simulation/SimulationAwarePlannerService.java # src/main/java/org/prebid/server/deals/simulation/SimulationAwareRegisterService.java # src/main/java/org/prebid/server/deals/simulation/SimulationAwareUserService.java # src/main/java/org/prebid/server/handler/admin/DealsStatusHandler.java # src/main/java/org/prebid/server/handler/admin/ForceDealsUpdateHandler.java # src/main/java/org/prebid/server/handler/admin/LineItemStatusHandler.java # src/main/java/org/prebid/server/handler/openrtb2/AuctionHandler.java # src/main/java/org/prebid/server/handler/openrtb2/VideoHandler.java # src/main/java/org/prebid/server/spring/config/DealsConfiguration.java # src/main/java/org/prebid/server/spring/config/server/admin/AdminEndpointsConfiguration.java # src/main/java/org/prebid/server/spring/config/server/application/ApplicationServerConfiguration.java # src/test/java/org/prebid/server/deals/AlertHttpServiceTest.java # src/test/java/org/prebid/server/deals/DeliveryStatsServiceTest.java # src/test/java/org/prebid/server/deals/PlannerServiceTest.java # src/test/java/org/prebid/server/deals/RegisterServiceTest.java # src/test/java/org/prebid/server/deals/UserServiceTest.java # src/test/java/org/prebid/server/deals/simulation/SimulationAwareHttpBidderRequesterTest.java # src/test/java/org/prebid/server/deals/simulation/SimulationAwarePlannerServiceTest.java # src/test/java/org/prebid/server/handler/DealsStatusHandlerTest.java # src/test/java/org/prebid/server/handler/ForceDealsUpdateHandlerTest.java # src/test/java/org/prebid/server/handler/LineItemStatusHandlerTest.java
# Conflicts: # src/main/java/org/prebid/server/auction/ExchangeService.java # src/test/groovy/org/prebid/server/functional/service/PrebidServerService.groovy # src/test/groovy/org/prebid/server/functional/tests/privacy/PrivacyBaseSpec.groovy # src/test/resources/org/prebid/server/it/deals/premature/responses/test-auction-first-and-second-response.json # src/test/resources/org/prebid/server/it/deals/premature/responses/test-auction-first-bid-only-response.json # src/test/resources/org/prebid/server/it/deals/premature/responses/test-auction-in-order-response.json # src/test/resources/org/prebid/server/it/deals/premature/responses/test-auction-in-reverse-order-response.json # src/test/resources/org/prebid/server/it/deals/premature/responses/test-auction-second-bid-only-response.json # src/test/resources/org/prebid/server/it/deals/premature/responses/test-auction-third-and-second-response.json # src/test/resources/org/prebid/server/it/deals/premature/responses/test-auction-third-bid-only-response.json # src/test/resources/org/prebid/server/it/deals/simulation/test-auction-response-1.json # src/test/resources/org/prebid/server/it/deals/simulation/test-auction-response-2.json # src/test/resources/org/prebid/server/it/deals/test-auction-response.json
CTMBNara
requested changes
Mar 7, 2024
src/main/java/org/prebid/server/handler/BidderParamHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/metrics/PrometheusConfiguration.java
Outdated
Show resolved
Hide resolved
.../java/org/prebid/server/spring/config/server/application/ApplicationServerConfiguration.java
Outdated
Show resolved
Hide resolved
.../java/org/prebid/server/spring/config/server/application/ApplicationServerConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/vertx/verticles/server/ServerVerticle.java
Outdated
Show resolved
Hide resolved
Net-burst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To bump Vert.x to version 4 we need to move from embedded usage (via ContextRunner class) to Vert.x verticles deployment model usage. This is due to updates in Vert.x internal context management.
Previously, we were obtaining new event loop contexts via
vertx.getOrCreateContext()calls from spring boot config classes. When spring boot bootstraps application context it runs all configurations on single thread. Since Vert.x 4, call tovertx.getOrCreateContext()is going to create new event loop context for the first time and put it in thread local variable, so subsequent calls will just return same event loop context. It breaks ContextRunner class) and our deployment model.So, we decided to switch to verticles deployment model, where each instance of deployed verticle is assigned new event loop context and that is guaranteed by contract. This way we are not relying on vertx internal implementation.