more cleanup

libraries/pbsExtensions/processors/eventTrackers.js

@@ -1,6 +1,6 @@
 import {EVENT_TYPE_IMPRESSION, EVENT_TYPE_WIN, TRACKER_METHOD_IMG} from '../../../src/eventTrackers.js';
 
-export function addWinTrackers(bidResponse, bid) {
+export function addEventTrackers(bidResponse, bid) {
   bidResponse.eventtrackers = bidResponse.eventtrackers || [];
   [
     [bid.burl, EVENT_TYPE_IMPRESSION], // core used to fire burl directly, but only for bids coming from PBS

libraries/pbsExtensions/processors/pbs.js

@@ -6,7 +6,7 @@ import {setImpBidParams} from './params.js';
 import {setImpAdUnitCode} from './adUnitCode.js';
 import {setRequestExtPrebid, setRequestExtPrebidChannel} from './requestExtPrebid.js';
 import {setBidResponseVideoCache} from './video.js';
-import {addWinTrackers} from "./eventTrackers.js";
+import {addEventTrackers} from "./eventTrackers.js";
 
 export const PBS_PROCESSORS = {
   [REQUEST]: {
@@ -77,7 +77,7 @@ export const PBS_PROCESSORS = {
     },
     pbsWinTrackers: {
       // converts "legacy" burl and ext.prebid.events.win into eventtrackers
-      fn: addWinTrackers
+      fn: addEventTrackers
     },
   },
   [RESPONSE]: {

test/spec/ortbConverter/pbsExtensions/trackers_spec.js

@@ -1,5 +1,5 @@
 import {EVENT_TYPE_IMPRESSION, EVENT_TYPE_WIN, TRACKER_METHOD_IMG} from '../../../../src/eventTrackers.js';
-import {addWinTrackers} from '../../../../libraries/pbsExtensions/processors/eventTrackers.js';
+import {addEventTrackers} from '../../../../libraries/pbsExtensions/processors/eventTrackers.js';
 
 describe('PBS event trackers', () => {
   let bidResponse;
@@ -32,18 +32,18 @@ describe('PBS event trackers', () => {
     }
 
     it(`should add ${t}`, () => {
-      addWinTrackers(bidResponse, bid);
+      addEventTrackers(bidResponse, bid);
       expect(getTracker()).to.exist;
     });
     it(`should append ${t}`, () => {
       bidResponse.eventtrackers = [{method: 123, event: 321, url: 'other-tracker'}];
-      addWinTrackers(bidResponse, bid);
+      addEventTrackers(bidResponse, bid);
       expect(getTracker()).to.exist;
       expect(bidResponse.eventtrackers.length).to.eql(2);
     });
     it('should NOT add a duplicate tracker', () => {
       bidResponse.eventtrackers = [{method: TRACKER_METHOD_IMG, event: type, url: 'tracker'}];
-      addWinTrackers(bidResponse, bid);
+      addEventTrackers(bidResponse, bid);
       expect(getTracker()).to.exist;
       expect(bidResponse.eventtrackers.length).to.eql(1);
     })

test/spec/unit/pbjs_api_spec.js

@@ -1381,17 +1381,19 @@ describe('Unit: Prebid Module', function () {
       });
     });
 
-    it('fires billing url if present on s2s bid', function () {
-      const burl = 'http://www.example.com/burl';
+    it('fires impression trackers if present', function () {
+      const url = 'http://www.example.com/burl';
       pushBidResponseToAuction({
         ad: '<div>ad</div>',
         source: 's2s',
-        burl
+        eventtrackers: [
+          {event: 1, method: 1, url}
+        ]
       });
 
       return renderAd(doc, bidId).then(() => {
         sinon.assert.calledOnce(triggerPixelStub);
-        sinon.assert.calledWith(triggerPixelStub, burl);
+        sinon.assert.calledWith(triggerPixelStub, url);
       });
     });