Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remote registry cache #129

Closed
wants to merge 2 commits into from
Closed

Conversation

VanishMax
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 3c6fdff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@conorsch conorsch self-requested a review February 13, 2025 19:46
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to disable caching altogether on the registry lookups. For frontends like the dex-explorer, that would result in a LOT of endpoint traffic, likely enough to generate 429s.

For those following along at home, I posted some context for these changes in penumbra-zone/dex-explorer#373, and I suggest we debug over there before making a drastic change like disabling registry caching altogether.

@VanishMax
Copy link
Contributor Author

Agree with you. I guess, since the cache is agressive but it still revalidates after some time, it's better than no caching at all. Closing this

@VanishMax VanishMax closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants