:hidden option simplification

prawnpdf · Jul 21, 2021 · 334c19a · 334c19a
1 parent 0fb2b56
commit 334c19a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/lib/prawn/embedded_files.rb b/lib/prawn/embedded_files.rb
@@ -32,7 +32,7 @@ def file(src, options = {})
       filespec = Filespec.new(file_obj, options)
       filespec_obj = filespec.build_pdf_object(self)
 
-      unless filespec.hidden
+      unless filespec.hidden?
         # Wait for pdf-core PR
 
         # attach_file(filespec.file_name, filespec_obj)

diff --git a/lib/prawn/embedded_files/filespec.rb b/lib/prawn/embedded_files/filespec.rb
@@ -3,7 +3,7 @@
 module Prawn
   module EmbeddedFiles
     class Filespec
-      attr_reader :file_name, :not_hidden
+      attr_reader :file_name
 
       def initialize(file, options = {})
         name = options[:name] || file.chksum
@@ -15,15 +15,12 @@ def initialize(file, options = {})
           @description = PDF::Core::LiteralString.new(desc_str)
         end
 
-        if options[:hidden].nil? || options[:hidden] != true
-          @not_hidden = true
-        end
-
+        @hidden = options[:hidden] == true
         @file = file
       end
 
-      def hidden
-        !@not_hidden
+      def hidden?
+        @hidden
       end
 
       def build_pdf_object(document)