-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bytes formatted images to submit_image and submit_gallery #1891
Open
redowul
wants to merge
21
commits into
praw-dev:master
Choose a base branch
from
redowul:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jul 26, 2022
-
Add support for bytes images to subreddit.py
Files modified: - submit_image - submit_gallery - _validate_gallery - _upload_media - _read_and_post_media Added new import: - from io import BytesIO Previously, to submit an image to Reddit a filepath to an image stored on the local machine needed to be provided to PRAW to pass through to the Reddit API. This fork changes this behavior by implementing support for bytes objects through the io library. What this means in practical terms: in the original code, the filepath is referenced to retrieve the image file and convert it to bytes format anyway. Now the bytes of an image can be directly passed through while still retaining the original filepath functionality. This means an image retrieved from a server does not need to be downloaded before it can be uploaded: it's String implementation can be passed along to Reddit instead.
Configuration menu - View commit details
-
Copy full SHA for ff844c4 - Browse repository at this point
Copy the full SHA ff844c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e75488d - Browse repository at this point
Copy the full SHA e75488dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0958a8c - Browse repository at this point
Copy the full SHA 0958a8cView commit details
Commits on Jul 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8a69680 - Browse repository at this point
Copy the full SHA 8a69680View commit details
Commits on Jul 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 32548cc - Browse repository at this point
Copy the full SHA 32548ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3838030 - Browse repository at this point
Copy the full SHA 3838030View commit details
Commits on Jul 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2c9b605 - Browse repository at this point
Copy the full SHA 2c9b605View commit details
Commits on Aug 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fc07624 - Browse repository at this point
Copy the full SHA fc07624View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb457bd - Browse repository at this point
Copy the full SHA fb457bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fe5070 - Browse repository at this point
Copy the full SHA 7fe5070View commit details -
Configuration menu - View commit details
-
Copy full SHA for f03eedc - Browse repository at this point
Copy the full SHA f03eedcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98c4cf4 - Browse repository at this point
Copy the full SHA 98c4cf4View commit details
Commits on Aug 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 681f5f5 - Browse repository at this point
Copy the full SHA 681f5f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33bc677 - Browse repository at this point
Copy the full SHA 33bc677View commit details
Commits on Aug 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b3e23ea - Browse repository at this point
Copy the full SHA b3e23eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97448bc - Browse repository at this point
Copy the full SHA 97448bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11ec479 - Browse repository at this point
Copy the full SHA 11ec479View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30762fb - Browse repository at this point
Copy the full SHA 30762fbView commit details
Commits on Aug 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ae18a50 - Browse repository at this point
Copy the full SHA ae18a50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98bf85b - Browse repository at this point
Copy the full SHA 98bf85bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9957bd2 - Browse repository at this point
Copy the full SHA 9957bd2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.