Issue 187: Add MQTT to Pravega bridge sample #188
Conversation
claudiofahey
force-pushed
the
issue-187-mqtt-pravega-bridge
branch
2 times, most recently
from
c736fd4
to
306d00b
Compare
|
@claudiofahey due to issues we had in previous releases merging |
claudiofahey
force-pushed
the
issue-187-mqtt-pravega-bridge
branch
from
1a0aea4
to
0c6deca
Compare
Signed-off-by: Claudio Fahey <[email protected]>
claudiofahey
force-pushed
the
issue-187-mqtt-pravega-bridge
branch
from
0c6deca
to
7b2d38e
Compare
claudiofahey
dismissed
vijikarthi’s stale review
suggested changes have been implemented
|
This PR is ready for re-review. |
| @@ -0,0 +1,51 @@ | |||
| package io.pravega.example.mqtt; | |||
| @@ -0,0 +1,82 @@ | |||
| package io.pravega.example.mqtt; | |||
| @@ -0,0 +1,60 @@ | |||
| package io.pravega.example.mqtt; | |||
| @@ -0,0 +1,56 @@ | |||
| package io.pravega.example.mqtt; | |||
| @@ -0,0 +1,76 @@ | |||
| package io.pravega.example.mqtt; | |||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
|
|
||
| Copyright (c) 2017 Dell Inc., or its subsidiaries. All Rights Reserved. |
There was a problem hiding this comment.
Remove year from copyright statement.
| @@ -0,0 +1,55 @@ | |||
| plugins { | |||
There was a problem hiding this comment.
We are adding license headers to such gradle files too, see pravega/pravega.
| # Pravega Properties | ||
| controllerUri=tcp://127.0.0.1:9090 | ||
| scope=examples | ||
| stream=mqtt-example |
There was a problem hiding this comment.
For a sample, writing to a single stream is ok, but in general, isn't it possible that we have use cases in which the same bridge writes to different streams, perhaps inferring the stream from the event data?
|
|
||
| private void loadProperties(String confDir) throws Exception{ | ||
| Properties prop = new Properties(); | ||
| try ( |
There was a problem hiding this comment.
Nit: In Pravega core, the style of these statements is in one line.
|
|
||
| public class ApplicationMain { | ||
|
|
||
| private static Logger log = LoggerFactory.getLogger( ApplicationMain.class ); |
There was a problem hiding this comment.
Nit: extra spaces within parenthesis.
| @@ -0,0 +1,39 @@ | |||
| package io.pravega.example.mqtt; | |||
There was a problem hiding this comment.
Agree on the license headers missing.
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
|
|
||
| Copyright (c) 2017 Dell Inc., or its subsidiaries. All Rights Reserved. |
There was a problem hiding this comment.
Same here about removing year from header.
|
@fpj @claudiofahey do we want to merge this for 0.8? |
Add MQTT to Pravega bridge sample.
A sample application reads events from MQTT and writes them to a Pravega stream.