Issue 85: turbineSensor throws occasional NPE #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts instead of consumeStats in reader and lack of null check parsing read events). Signed-off-by: Raúl Gracia <[email protected]>
vijikarthi
approved these changes
Jun 15, 2018
EronWright
approved these changes
Jun 15, 2018
fpj
reviewed
Jun 18, 2018
| return CompletableFuture.completedFuture(null); | ||
| }, Long.parseLong(result.getEvent().split(",")[0]), 100); | ||
| totalEvents--; | ||
| } | ||
| } catch (ReinitializationRequiredException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Let's create an issue to remove this print stack trace.
There was a problem hiding this comment.
Ok, I will create it.
fpj
pushed a commit
that referenced
this pull request
Jun 23, 2018
* Fix in TurbineHeatSensor.java to avoid the application to throw NullPointerException. Note that this PR only targets this specific problem (i.e., other exceptions or problems will be treated separately). Signed-off-by: Raúl Gracia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Fix in
TrubineHeatSensor.javafor avoiding the application to throwNullPointerException. Note that this PR only targets this specific problem (i.e., other exceptions or problems will be treated separately).Purpose of the change
Fixes #85.
What the code does
The reader (
SensorReader) is incorrectly interacting withproduceStatsinstead of withconsumeStats. Moreover, the read loop of this class parses read events without checking for null events (e.g., after timeout). The fix consists of replacing reader interactions fromproduceStatstoconsumeStatsas well as to check for a null read event before executing the parse logic.How to verify it
Execute the application and verify that it does not throws NPE.