configuration for retry #26 #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any progress? 🤔 I think this should be applied. I cannot control retrying connection, as it gets done unconditionally! 😥 |
|
It's been a long time, I'll take a look and see what hapenned. |
|
@tolgaerdonmez @dolbin-prime sorry for the delay. I'll get this PR reviewed and merged this weekend. |
mjohlke
reviewed
Jan 24, 2025
| ); | ||
| }); | ||
| if (config.infinite || (config.tryCount ?? 0) > 0) { | ||
| Future.delayed(Duration(seconds: 5), () { |
There was a problem hiding this comment.
I would like to hint to the html spec where they list a retry event which is meant to control the reconnection time in milliseconds.
Adding a field int reconnectTime to RetryConfiguration and use this instead of the static 5s for the timer might be a good starting point. What I am not sure about is if these retry-events should set reconnectTime automatically or if this should be up to the programmer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #26
I've added a retry configuration, I can modify, if you'll say so. just have a look and let's merge this.