Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more supported YT links #53

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

drogga
Copy link
Contributor

@drogga drogga commented Jul 25, 2024

No description provided.

@drogga
Copy link
Contributor Author

drogga commented Jul 25, 2024

@prateek-chaubey I hope you can merge this asap, so we can move onto the next thing...

@drogga
Copy link
Contributor Author

drogga commented Aug 10, 2024

@prateek-chaubey
Any ETA or why haven't you still merged this, given that there just has been a new ver. ?, because I would like to eventually delete my fork.

@prateek-chaubey
Copy link
Owner

All the pull requests will be added prior to the next major release after validation

@drogga
Copy link
Contributor Author

drogga commented Feb 5, 2025

The repo is always open for contributions , there are a lot of things that can be added and a lot of things that have to be patched as well.

It's just this one open for months, let's not turn into years... There aren't much contributors and it's not helping keeping them / us waiting.
Should I hope for a merge this year so I can move along ?
It's a basic commit, just a few additions to the manifest, nothing major, fancy or anything that can break any functionality, should've been merged long time ago, given that there are no conflicts, IDK what's the hold up for...

I don't think I'll be creating any other PRs again, seeing how this goes, that's why I don't want to contribute with changes, only suggestions. I'm tired of excuses.

People are making mods of it, just to add the same thing I did here and that can be implemented with a click of a button.

@prateek-chaubey
Copy link
Owner

Damm i forgot about this PR
lemme do it

@prateek-chaubey prateek-chaubey merged commit a66cd1a into prateek-chaubey:main Feb 5, 2025
1 check passed
@prateek-chaubey
Copy link
Owner

sorry for that , i literally forgot about it
btw i merged it now , and will update the apk file in the releases section.

@drogga
Copy link
Contributor Author

drogga commented Feb 5, 2025

👍 Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants