Nginx fixes #997
Merged
Nginx fixes #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usage of "array" parameters like ?ids[]=xxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I had to move some webapps from Apache to Nginx.
While apps working in the main domain folder (eg. www.test.com/) works fine, apps running in a subfolder (eg. www.test.com/app/) has problems in determining the requested page when
THttpRequest'sUrlFormatis set toPathorHiddenPath.This PR contains 2 changes.
The first one adds some fallbacks for determining the requested page path (pathInfo) when the app is using
PathorHiddenPathurl formats.The second change adds a urldecode() call to request parameters when the app is using
PathorHiddenPathurl formats. This is meant to fix a niche problem when using array parameters, aka "repeated parameters" from rfc1738, eg: www.test.com/page,Home/ids[],1/ids[],2/ids[],3Without the urldecode the square brackets would appear like eg: www.test.com/page,Home/ids%5B%5D,1/ids%5B%5D,2/ids%5B%5D,3