-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make zero deps pkg #67
base: main
Are you sure you want to change the base?
Conversation
083a420
to
26d6932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while I am not against removing this dependency, I tested that code manually in various scenarios when I wrote the logic. Doing the following change might break stuff for some users, and would be pretty hard to check as I didn't write tests for all the scenarios I was covering with that logic.
I think we need a few tests to verify that everything is working as before before merging this one.
Which ones exactly? I added a simple unit test for the new method, it can be extended. |
@antongolub iirc it was mostly in monorepos with various package managers and settings as it was creating some issues |
tslib
find-up
with node API