Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make zero deps pkg #67

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

antongolub
Copy link
Contributor

  • build the plugin itself with esbuild, drop tslib
  • replace find-up with node API

Copy link
Owner

@pradel pradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I am not against removing this dependency, I tested that code manually in various scenarios when I wrote the logic. Doing the following change might break stuff for some users, and would be pretty hard to check as I didn't write tests for all the scenarios I was covering with that logic.
I think we need a few tests to verify that everything is working as before before merging this one.

.github/workflows/node.js.yml Outdated Show resolved Hide resolved
esbuild-node-externals/package.json Outdated Show resolved Hide resolved
@antongolub
Copy link
Contributor Author

I tested that code manually in various scenarios when I wrote the logic.

Which ones exactly? I added a simple unit test for the new method, it can be extended.

@antongolub antongolub requested a review from pradel October 4, 2024 19:12
@pradel
Copy link
Owner

pradel commented Oct 14, 2024

@antongolub iirc it was mostly in monorepos with various package managers and settings as it was creating some issues

@antongolub
Copy link
Contributor Author

antongolub commented Oct 29, 2024

@pradel

We can publish a snapshot version for manual testing without merging this PR: #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants