Fix multiple diagnostic virtual text per-line of same severity in vim #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the prop_remove just before prop_add in place_virtual_text, since this function is called after clear_virtual_text is called to clear the previously added virtual text. That way, if there are multiple virtual text to place on the same line with the same severity, the following ones don't replace the former ones. Besides, the branch for neovim wasn't removing any property, so this should make it consistent with neovim.
dylanahsmith
force-pushed
the
multi-virtual-text-per-line
branch
from
15be5fd to
2fe21f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the prop_remove just before prop_add in place_virtual_text, since this function is called after clear_virtual_text is called to clear the previously added virtual text.
That way, if there are multiple virtual text to place on the same line with the same severity, the following ones don't replace the former ones. Besides, the branch for neovim wasn't removing any property, so this should make it consistent with neovim.