Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running complete_done_after() in normal mode #1429

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

infmagic2047
Copy link
Contributor

If user selects a completion item and presses <Esc>, the key sequence to feedkeys() will get run in normal mode. This can be handled with a <Plug> mapping that resolves to different sequences in normal mode and insert mode.

As a bonus, the use of <silent> mappings eliminate the message line garbage from feedkeys.

@stale
Copy link

stale bot commented Apr 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 2, 2023
@prabirshrestha
Copy link
Owner

@infmagic2047 could you fix merge conflicts.

If user selects a completion item and presses <Esc>, the key sequence to
feedkeys() will get run in normal mode. This can be handled with a
<Plug> mapping that resolves to different sequences in normal mode and
insert mode.

As a bonus, the use of <silent> mappings eliminate the message line
garbage from feedkeys.
@infmagic2047 infmagic2047 force-pushed the completedone-normalmode branch from 874a63d to a760749 Compare June 14, 2023 07:51
@infmagic2047
Copy link
Contributor Author

I just rebased on master.

@stale
Copy link

stale bot commented Aug 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants