Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixed // new maxlength input prop #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bug fixed // new maxlength input prop #26

wants to merge 3 commits into from

Conversation

soleyj
Copy link

@soleyj soleyj commented Jun 9, 2022

Bug Fixed:

  • If enter blank text, the tag counter increase. So if you have maxtag set to 20 , will be limited to 19 and don't allow entering one more.
  • Copy/paste only one element, don't check duplicated.

Feature:

  • Add max length input prop if user want to add this setting.

soleyj added 3 commits June 9, 2022 12:38
@soleyj
fix copy past one element
76ececf 
if only copy paste one element, element can be duplicated if allowDuplicates is active.

Now we check also if is only one element and don't allow duplication.
@soleyj
add max length input prop
2384171
@soleyj
fix count blanc as total tag
e024faa 
blancs increment count in total tag. So if you enter 1 blanc the max tag will be limited to 19 ( if max tag are 20 )

so if the input is blanc return the function.
@vercel
Copy link

vercel bot commented Jun 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
smart-tagz ❌ Failed (Inspect) Jun 13, 2022 at 11:55AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@soleyj