Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sonar security issue #458

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

prabhuignoto
Copy link
Owner

replacing Math.random with custom getUniqueId function

Description

  • replace Math.random calls with custom getUniqueId Function for generating unique ids

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

replacing Math.random with custom getUniqueId function
Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-chrono-uc7v ✅ Ready (Inspect) Visit Preview Jan 17, 2024 6:22am

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/react-chrono.js 30.94 KB (0%) 619 ms (0%) 40 ms (+173.16% 🔺) 658 ms
dist/react-chrono.esm.js 31.07 KB (0%) 622 ms (0%) 32 ms (+120.46% 🔺) 653 ms
dist/react-chrono.umd.js 34.11 KB (+0.09% 🔺) 683 ms (+0.09% 🔺) 26 ms (+75.29% 🔺) 708 ms

@prabhuignoto prabhuignoto merged commit d51984a into master Jan 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant