Added callbacks for onNext and onPrevious and Alternated by default horizontal timeline #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…times, if the title is long, collapses with the nearer one. Updated also app sample.
…ódigo directamente. 1.14.7 para probar a ver si pone el código cambiado arriba.
…-chrono # Conflicts: # package.json
prabhuignoto
reviewed
Mar 8, 2022
| @@ -0,0 +1,6 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
we should not be checking in the dist folder. is there a specific reason for adding it
prabhuignoto
reviewed
Mar 8, 2022
Comment on lines
+1
to
+56
| /// <reference types="react" /> | ||
| import { Theme } from '../../../models/Theme'; | ||
| import { TimelineMode } from '../../../models/TimelineModel'; | ||
| export declare const TimelineNavWrapper: import("@emotion/styled").StyledComponent<{ | ||
| theme?: import("@emotion/react").Theme | undefined; | ||
| as?: import("react").ElementType<any> | undefined; | ||
| } & { | ||
| theme?: Theme | undefined; | ||
| }, import("react").DetailedHTMLProps<import("react").HTMLAttributes<HTMLUListElement>, HTMLUListElement>, {}>; | ||
| export declare const TimelineNavItem: import("@emotion/styled").StyledComponent<{ | ||
| theme?: import("@emotion/react").Theme | undefined; | ||
| as?: import("react").ElementType<any> | undefined; | ||
| } & { | ||
| disable?: boolean | undefined; | ||
| }, import("react").DetailedHTMLProps<import("react").LiHTMLAttributes<HTMLLIElement>, HTMLLIElement>, {}>; | ||
| export declare const TimelineNavButton: import("@emotion/styled").StyledComponent<{ | ||
| theme?: import("@emotion/react").Theme | undefined; | ||
| as?: import("react").ElementType<any> | undefined; | ||
| } & { | ||
| mode?: TimelineMode | undefined; | ||
| rotate?: "TRUE" | "FALSE" | undefined; | ||
| theme?: Theme | undefined; | ||
| }, import("react").DetailedHTMLProps<import("react").ButtonHTMLAttributes<HTMLButtonElement>, HTMLButtonElement>, {}>; | ||
| export declare const TimelineControlContainer: import("@emotion/styled").StyledComponent<{ | ||
| theme?: import("@emotion/react").Theme | undefined; | ||
| as?: import("react").ElementType<any> | undefined; | ||
| } & { | ||
| flip?: boolean | undefined; | ||
| slideShowActive?: boolean | undefined; | ||
| }, import("react").DetailedHTMLProps<import("react").HTMLAttributes<HTMLDivElement>, HTMLDivElement>, {}>; | ||
| export declare const ControlButton: import("@emotion/styled").StyledComponent<{ | ||
| theme?: import("@emotion/react").Theme | undefined; | ||
| as?: import("react").ElementType<any> | undefined; | ||
| } & { | ||
| theme?: Theme | undefined; | ||
| }, import("react").DetailedHTMLProps<import("react").ButtonHTMLAttributes<HTMLButtonElement>, HTMLButtonElement>, {}>; | ||
| export declare const MediaToggle: import("@emotion/styled").StyledComponent<{ | ||
| theme?: import("@emotion/react").Theme | undefined; | ||
| as?: import("react").ElementType<any> | undefined; | ||
| } & { | ||
| theme?: Theme | undefined; | ||
| } & import("react").ClassAttributes<HTMLButtonElement> & import("react").ButtonHTMLAttributes<HTMLButtonElement> & { | ||
| children?: import("react").ReactNode; | ||
| } & { | ||
| theme?: import("@emotion/react").Theme | undefined; | ||
| }, {}, {}>; | ||
| export declare const ReplayWrapper: import("@emotion/styled").StyledComponent<{ | ||
| theme?: import("@emotion/react").Theme | undefined; | ||
| as?: import("react").ElementType<any> | undefined; | ||
| } & { | ||
| theme?: Theme | undefined; | ||
| } & import("react").ClassAttributes<HTMLButtonElement> & import("react").ButtonHTMLAttributes<HTMLButtonElement> & { | ||
| children?: import("react").ReactNode; | ||
| } & { | ||
| theme?: import("@emotion/react").Theme | undefined; | ||
| }, {}, {}>; |
There was a problem hiding this comment.
we don't need to check in the dist folder.
|
Kudos, SonarCloud Quality Gate passed!
|
ajmeese7
reviewed
Aug 26, 2024
| @@ -22,11 +22,9 @@ npm-debug.log* | |||
| yarn-debug.log* | |||
| yarn-error.log* | |||
|
|
|||
| /dist | |||
There was a problem hiding this comment.
This PR would be ready if this change was removed, that way all the dist code that was checked would be deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added callbacks for onNext and onPrevious and Alternated by default horizontal timeline
Additional context
It´s been a quick fix to solve a problem for our usage, use it for your need or adapt it :)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).