Skip to content

Commit

Permalink
alternate build count strategy for postgres
Browse files Browse the repository at this point in the history
  • Loading branch information
bradrydzewski committed May 2, 2018
1 parent 6a651f1 commit 9ffd5ad
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 18 deletions.
6 changes: 6 additions & 0 deletions store/datastore/builds_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,12 @@ func TestBuilds(t *testing.T) {
g.Assert(builds[0].RepoID).Equal(build2.RepoID)
g.Assert(builds[0].Status).Equal(build2.Status)
})

g.It("Should count Builds", func() {
count, err := s.GetBuildCount()
g.Assert(err == nil).IsTrue()
g.Assert(count > 0).IsTrue()
})
})
}

Expand Down
3 changes: 1 addition & 2 deletions store/datastore/sql/postgres/files/counts.sql
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,4 @@ WHERE repo_active = true

-- name: count-builds

SELECT reltuples
FROM pg_class WHERE relname = 'builds'
SELECT currval('builds_build_id_seq');
17 changes: 1 addition & 16 deletions store/datastore/sql/postgres/sql_gen.go
Original file line number Diff line number Diff line change
@@ -1,17 +1,3 @@
// Copyright 2018 Drone.IO Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package postgres

// Lookup returns the named statement.
Expand Down Expand Up @@ -108,8 +94,7 @@ WHERE repo_active = true
`

var countBuilds = `
SELECT reltuples
FROM pg_class WHERE relname = 'builds'
SELECT currval('builds_build_id_seq');
`

var feedLatestBuild = `
Expand Down

0 comments on commit 9ffd5ad

Please sign in to comment.