Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Small fixes to avoid compilation issues #4

Closed
wants to merge 3 commits into from
Closed

Conversation

nmurilo
Copy link

@nmurilo nmurilo commented Mar 28, 2024

No description provided.

@murraybot
Copy link

Yes! I just commented out those two imports myself and everything still seemed to work fine. Another thing that should be added to the readme section describing how to build from source is that the deauth function needs to be silenced manually, like the instructions here. Also, the readme says to submit bugs to GitHub issues, but there is no issues tab.

@pr3y
Copy link
Owner

pr3y commented Apr 15, 2024

Yes! I just commented out those two imports myself and everything still seemed to work fine. Another thing that should be added to the readme section describing how to build from source is that the deauth function needs to be silenced manually, like the instructions here. Also, the readme says to submit bugs to GitHub issues, but there is no issues tab.

i updated the README and added the issues tab, thanks!
also this PR appears to have conflicts on actions, what version of arduino IDE are you guys using to get this error? i didn't saw any on build with 2.3.2 (maybe it depends on library versions also), but anyways now there is the actions trying to compile it for us and failing :P

@murraybot
Copy link

Yes! I just commented out those two imports myself and everything still seemed to work fine. Another thing that should be added to the readme section describing how to build from source is that the deauth function needs to be silenced manually, like the instructions here. Also, the readme says to submit bugs to GitHub issues, but there is no issues tab.

i updated the README and added the issues tab, thanks! also this PR appears to have conflicts on actions, what version of arduino IDE are you guys using to get this error? i didn't saw any on build with 2.3.2 (maybe it depends on library versions also), but anyways now there is the actions trying to compile it for us and failing :P

I was compiling v0.7 when I ran into the issues, and commenting out the SD.h include in PCAP.h and sniffer.h solved the issue. My Arduino IDE version is also 2.3.2, it could depend on the libraries, but commenting out those includes didn't seem to cause any compile issues for me and I believe it is still writing pcap logs.

I'm not sure why the action isn't building, I am still really green to Git in general.

@pr3y pr3y closed this Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants