Inputs in dedicated Task #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inputs (chechSelPress and stuff) are checked in a specific task, running on background Removed delay before and after loopOptions
rouing
approved these changes
Jan 2, 2025
|
I've changed many thing already.. the crashes was due to stack size.. Next step will acommodate all keyboards into one code |
Added a function to control the Input variables, now they "rearm" after read. Fixed Restarts and some other changes Fixed Keyboard to send Delete key and modifiers pr3y#594
Removed keyboard function from interface.cpp, all devices are now usinf the same function, easy to maintain Remapped TouchArea for touchscreen devices.. now it is possible to use the touch area to escape some functions, go up/down/left/right and selec
|
I believe it is good for merge now.. tested on all boards and its working good.. All tested and passed here |
These libs are now being included in the specific environment, getting t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Changed the functions checkPrevPress, checkSelPress, checkNextPress, checkEscPress and checkAnyKeyPress to volatile bool variables and made them run on a InputHandler function on a dedicated task.
Added debounce into the InputHandler, removing some delays from the code (the ones before and after loopOption callings.
Touch bar for CYD, Core2 and CoreS3 is now the whole screen (left side for prev, center for Select and right for Next, more options can be added now, if needed, like Esc btn as an [X] on screen)
Types of Changes
Structural
Verification
Overall speed might be improved in loopTask.
Testing
Need to test on all devices, can be tested in this flasher (using BetaRelease)
DO NOT MERGE YET, Please...
@rouing Can you have a look on it?