[TEST] Update CBMC to #8573 #688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
changed the title
hanno-becker
force-pushed
the
cbmc_patch
branch
from
ad937b5 to
21d7b4f
Compare
7 tasks
|
Fix from diffblue/cbmc#8574 works for MLKEM-512 and MLKEM-768. MLKEM-1024 still times out -- investigating. |
This commit tests the mlkem-native CBMC proofs with the current upstream d4757e2231b236ddd1d1933b4002a5aa4ca36db9 of CBMC. This merges diffblue/cbmc#8562 solving a soundness issue we previously reported, but was noted to sometimes cause performance regressions. Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
cbmc_patch
branch
from
24893bf to
6e87470
Compare
hanno-becker
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tests the mlkem-native CBMC proofs with diffblue/cbmc#8573. This includes diffblue/cbmc#8562 solving a soundness issue we previously reported, but was noted to sometimes cause performance regressions.
Opening this PR to check whether proofs remain functional and practical in mlkem-native.