Integrate ACVP python script #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potsrevennil
force-pushed
the
integrate_acvp
branch
25 times, most recently
from
1ab82f8
to
16fc6bc
Compare
mkannwischer
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Thanks @potsrevennil. Overall the changes look good.
Unfortunately if I change a testvector and run it again, it prints an error, but happily continues and returns 0 - so this is not going to fail in CI.
Can you please make sure that this actually fails in CI when a tectvector does not match.
potsrevennil
force-pushed
the
integrate_acvp
branch
from
16fc6bc
to
ba99fb9
Compare
mkannwischer
force-pushed
the
integrate_acvp
branch
from
ba99fb9
to
bc1053c
Compare
mkannwischer
approved these changes
Nov 12, 2024
Signed-off-by: Thing-han, Lim <[email protected]>
…efix/extra_args for extendibility Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
mkannwischer
force-pushed
the
integrate_acvp
branch
from
bc1053c
to
b38de3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests#257test/acvp_client.pytoscripts/acvp, which is used inquickcheckonlytests acvptests all